[DPE-4345] Disable pgBackRest service initialisation #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…up-test Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ckrest-service-initialisation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 70.05% 70.81% +0.75%
==========================================
Files 11 11
Lines 3016 3022 +6
Branches 535 536 +1
==========================================
+ Hits 2113 2140 +27
+ Misses 785 765 -20
+ Partials 118 117 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
changed the title
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
dragomirp
approved these changes
Jul 12, 2024
lucasgameiroborges
approved these changes
Jul 15, 2024
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ices-on-initialisation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
lucasgameiroborges
approved these changes
Jul 15, 2024
…ices-on-initialisation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The pgBackRest TLS service is enabled in the Snap, which makes it start automatically on boot in the charm, creating some noise in the system logs, like the following (from #468):
charmed-postgresql.pgbackrest-service[7546]: ERROR: [037]: server command requires option: tls-server-authSolution
Update the snap.
Also, restart the services that were already enabled if the unit reboots (in
src/charm.py).This PR depends on canonical/charmed-postgresql-snap#41. After that PR is merged, I'll switch the snap back to the right track and revisions in
src/constants.py.